[HttpFoundation] Drop support for ApacheRequest #32255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's do it with BC: 4.4 with deprecation, removal in 5.0. We should play safe. |
|
Done 👍 |
xabbuh
reviewed
Jun 28, 2019
xabbuh
reviewed
Jun 28, 2019
nicolas-grekas
approved these changes
Jun 28, 2019
norkunas
suggested changes
Jun 28, 2019
ogizanagi
approved these changes
Jun 28, 2019
fabpot
reviewed
Jun 28, 2019
Tobion
approved these changes
Jun 28, 2019
|
please fix your commit message |
xabbuh
approved these changes
Jun 28, 2019
|
Failures on AppVeyor not related
|
fabpot
approved these changes
Jul 1, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Drop support for ApacheRequest | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `ApacheUrlMatcher` has been [deprecated in 2.7](#12728) and removed in 3.0 I think we forgot to remove this class too. This class in never used in symfony, and there are no more reference in the documentation. Commits ------- f82e28c [HttpFoundation] Deprecated ApacheRequest
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApacheUrlMatcherhas been deprecated in 2.7 and removed in 3.0I think we forgot to remove this class too.
This class in never used in symfony, and there are no more reference in
the documentation.