-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[2.3] [Bridge] [Doctrine] made session table columns configurable through cons... #13136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3] [Bridge] [Doctrine] made session table columns configurable through cons... #13136
Conversation
hhamon
commented
Dec 27, 2014
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | ~ |
License | MIT |
Doc PR | ~ |
…onstructor method.
It's almost a new feature but it's still BC. |
This is a new feature and it's not compatible with https://github.com/hhamon/symfony/blob/configurable-doctrine-dbal-session-handler/src/Symfony/Bridge/Doctrine/HttpFoundation/DbalSessionHandlerSchema.php So the schema would need to be configurable as well. |
-1 for putting this in 2.3 |
@stof Shall it be merged into 2.7 instead? |
@stof should I close the PR or submit against 2.7? |
What is the state here? It must be done in 2.7 and it must also make the schema configurable. In it's current form it's not mergeable. @hhamon are you going to make the changes? Or rather close the PR? |
@Tobion I can make the changes in the coming days and submit against 2.7 branch. |
But what's the actual advantage of that? I don't really see it. As a session user you don't care how the table looks like. |
Should be done in 2.8 or closed. ping @hhamon |
Will do ;) |
Closing in favor of #14710. |