Skip to content

[2.3] [Bridge] [Doctrine] made session table columns configurable through cons... #13136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Dec 27, 2014

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@hhamon
Copy link
Contributor Author

hhamon commented Dec 27, 2014

It's almost a new feature but it's still BC.

@Tobion
Copy link
Contributor

Tobion commented Dec 28, 2014

This is a new feature and it's not compatible with https://github.com/hhamon/symfony/blob/configurable-doctrine-dbal-session-handler/src/Symfony/Bridge/Doctrine/HttpFoundation/DbalSessionHandlerSchema.php

So the schema would need to be configurable as well.

@stof
Copy link
Member

stof commented Dec 28, 2014

-1 for putting this in 2.3

@hhamon
Copy link
Contributor Author

hhamon commented Dec 29, 2014

@stof Shall it be merged into 2.7 instead?

@hhamon
Copy link
Contributor Author

hhamon commented Dec 31, 2014

@stof should I close the PR or submit against 2.7?

@fabpot fabpot added the Doctrine label Jan 2, 2015
@Tobion
Copy link
Contributor

Tobion commented Mar 17, 2015

What is the state here? It must be done in 2.7 and it must also make the schema configurable. In it's current form it's not mergeable. @hhamon are you going to make the changes? Or rather close the PR?

@hhamon
Copy link
Contributor Author

hhamon commented Mar 18, 2015

@Tobion I can make the changes in the coming days and submit against 2.7 branch.

@Tobion
Copy link
Contributor

Tobion commented Mar 18, 2015

But what's the actual advantage of that? I don't really see it. As a session user you don't care how the table looks like.

@fabpot
Copy link
Member

fabpot commented May 16, 2015

Should be done in 2.8 or closed. ping @hhamon

@hhamon
Copy link
Contributor Author

hhamon commented May 16, 2015

Will do ;)

@hhamon
Copy link
Contributor Author

hhamon commented May 21, 2015

Closing in favor of #14710.

@hhamon hhamon closed this May 21, 2015
@hhamon hhamon deleted the configurable-doctrine-dbal-session-handler branch December 29, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants