[Form] Remove deprecated setDefaultOptions and OptionsResolverInterface #13407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterrehm
commented
Jan 13, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | symfony/symfony-docs#4786 |
| Related | #12891 |
|
Rebased, good for review. |
|
Also removed the OptionsResolverInterface and it's usages. |
|
@stof Can you have a look at those changes? Tests are failing, but looks unrelated... |
|
Anyone up for a review? |
|
Looks ok 👍 |
|
Thank you @peterrehm. |
fabpot
added a commit
that referenced
this pull request
Feb 5, 2015
…ResolverInterface (peterrehm) This PR was merged into the 3.0-dev branch. Discussion ---------- [Form] Remove deprecated setDefaultOptions and OptionsResolverInterface | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#4786 | Related | #12891 Commits ------- 9b9158b Remove the deprecated OptionsResolverInterface 6026781 Removed deprecated setDefaultOptions methods
Merged
stof
added a commit
that referenced
this pull request
Dec 5, 2015
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #16752). Discussion ---------- [Form] document changes to form type interfaces | Q | A | ------------- | --- | Fixed tickets | #13407, #16024, #16724, #16749 | License | MIT Commits ------- b297a0c [Form] document changes to form type interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.