[Form] document changes to form type interfaces #16752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 30, 2015
| Q | A |
|---|---|
| Fixed tickets | #13407, #16024, #16724, #16749 |
| License | MIT |
| @@ -114,6 +114,12 @@ UPGRADE FROM 2.x to 3.0 | |||
|
|
|||
| ### Form | |||
|
|
|||
| * The `getBlockPrefix()` method was added to the `FormTypeInterface` in favor of | |||
| the `getName()` method which has been has been removed. | |||
There was a problem hiding this comment.
In general, the sentence is rather as follows:
The `FormTypeInterface::getName()` method has been removed in favor of
the `FormTypeInterface::getBlockPrefix()` method.There was a problem hiding this comment.
@ogizanagi the BC break in 3.0 is that the method was added in the interface
| @@ -114,6 +114,12 @@ UPGRADE FROM 2.x to 3.0 | |||
|
|
|||
| ### Form | |||
|
|
|||
| * The `getBlockPrefix()` method was added to the `FormTypeInterface` in replacement of | |||
| the `getName()` method which has been has been removed. | |||
| * The `configureOptions()` method was added to the `FormTypeInterface` in replacement | |||
There was a problem hiding this comment.
It would be good to show the different signature to reflect the change from OptionsResolverInterface to OptionsResolver
|
Thank you @xabbuh. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #16752). Discussion ---------- [Form] document changes to form type interfaces | Q | A | ------------- | --- | Fixed tickets | #13407, #16024, #16724, #16749 | License | MIT Commits ------- b297a0c [Form] document changes to form type interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.