[FrameworkBundle] Update assets configuration tests #13800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Just take this https://github.com/symfony/symfony/pull/13762/files#diff-571d03a9961a555687c1d3dd971b56daL137 and master should be green |
|
To actually make the build green, we also need #13801. |
|
Ok, I just made all the build fixes part of this PR. |
|
👍 |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Feb 26, 2015
…zal) This PR was merged into the 3.0-dev branch. Discussion ---------- [FrameworkBundle] Update assets configuration tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Previously, assets where enabled if `templating` didn't contain asset configuration. This has been removed in #13666. Instead of enabling it back I propose to keep it disabled and update the tests instead, since we already discussed disabling all FrameworkBundle features by default for 3.0 (#13703). Commits ------- 5007b41 [Form] Replace use of bind() with submit() in a test. 494e300 [SecurityBundle] Enable assets in functional tests. 4c26875 [FrameworkBundle] Fix a default config test case and add a new one for enabling assets. b0f6a19 [FrameworkBundle] Remove a legacy test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, assets where enabled if
templatingdidn't contain asset configuration. This has been removed in #13666.Instead of enabling it back I propose to keep it disabled and update the tests instead, since we already discussed disabling all FrameworkBundle features by default for 3.0 (#13703).