[Debug] Fix ClassNotFoundFatalErrorHandler candidates lookups #14451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ce25ef to
f52e8c3
Compare
|
This is a cherry-pick of 17f61af augmented with more strictness when looking up for candidates. |
| $symfonyUniversalClassLoader = new SymfonyUniversalClassLoader(); | ||
| $symfonyUniversalClassLoader->registerPrefixes($prefixes); | ||
| } else { | ||
| $symfonyUniversalClassLoader = $symfonyAutoloader; |
There was a problem hiding this comment.
shouldn't you ignore this test in this case instead of transforming it into a duplicate test by reusing the non-deprecated loader ?
f52e8c3 to
98ed078
Compare
|
I added a test with a wrapping DebugClassLoader and better isolated the legacy one. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 24, 2015
…ups (nicolas-grekas) This PR was merged into the 2.6 branch. Discussion ---------- [Debug] Fix ClassNotFoundFatalErrorHandler candidates lookups | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14447 | License | MIT | Doc PR | - This is already tested: 2.7 fails because this patch is missing. Commits ------- 98ed078 [Debug] Fix ClassNotFoundFatalErrorHandler candidates lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already tested: 2.7 fails because this patch is missing.