[Templating] Remove the component from the core #15029
Conversation
|
Rebased with the latest changes in 2.8. |
| @@ -19,7 +19,8 @@ | |||
| "php": ">=5.3.9", | |||
| "doctrine/common": "~2.3", | |||
| "twig/twig": "~1.18", | |||
| "psr/log": "~1.0" | |||
| "psr/log": "~1.0", | |||
| "symfony/templating": "~2.8" | |||
There was a problem hiding this comment.
I would instead add it in FrameworkBundle composer.json file. What do you think?
There was a problem hiding this comment.
The dependency already exists in the FrameworkBundle, which is ok. We need to add this dependency here to keep BC, so, if someone requires the symfony/symfony:~2.8 package can use the Templating component without any extra change in the composer.json file.
There was a problem hiding this comment.
I'm not quite sure it should be removed in 2.8 rather than 3.0 (where this line will be useless basically)...
There was a problem hiding this comment.
@Taluu the idea is to remove the componentes un 2.8, add it as a dependency and provide a templating bundle like the security acl
There was a problem hiding this comment.
How about putting it in the suggest section then ? And as @fabpot said, I think the dependency in the framework bundle is enough (having to add one line to the composer.json file is fine I think, with a proper upgrade message ofc)
There was a problem hiding this comment.
We can't add it to the suggest section to keep BC. In 3.0 we can.
The dep in the framework bundle is not enough, only works if someone install the symfony/framework-bundle package, but if someone uses the full framework requiring symfony/symfony the dep will not be installed.
|
@fabpot If you agree with my previous comment, I think that we can merge this one. |
|
@dosten rebase is needed here again :) |
|
@jakzal done! |
|
The feature freeze is soon. We should make a decision. |
|
Before doing this, it should work well, which is (unfortunately) not the case yet. See #15970 for a first PR that improve the current situation. |
|
Shouldn't we also trigger a deprecation when developers use the |
|
@xabbuh Indeed, that would be a nice step towards the end goal. |
|
Closing this PR as we won't be ready to merge this for 3.0, there are still to much feature that need to be deprecated first. We can revisit this later on of course. |
|
A quick question: could this deprecation be done in 3.1, 3.2, etc. or should we wait for 4.0? |
|
@javiereguiluz deprecations can happen in any minor version. Removal happens in next major. Btw, deprecating in the new major version looks like the forbidden case: the major version is here to remove deprecated layers, not to deprecate new things itself (things should be deprecated in the last minor version before it, like 2.8 vs 3.0) |
|
We can definitely deprecate this in 3.1. |
Hi there!
This PR is part of the extraction of the Templating component, to keep BC i've added
symfony/templatingas a dependency in the rootcomposer.json.