Skip to content

[Templating] Remove the component from the core #15029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Templating] Remove the component from the core #15029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"php": ">=5.3.9",
"doctrine/common": "~2.3",
"twig/twig": "~1.18",
"psr/log": "~1.0"
"psr/log": "~1.0",
"symfony/templating": "~2.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead add it in FrameworkBundle composer.json file. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency already exists in the FrameworkBundle, which is ok. We need to add this dependency here to keep BC, so, if someone requires the symfony/symfony:~2.8 package can use the Templating component without any extra change in the composer.json file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure it should be removed in 2.8 rather than 3.0 (where this line will be useless basically)...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taluu the idea is to remove the componentes un 2.8, add it as a dependency and provide a templating bundle like the security acl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting it in the suggest section then ? And as @fabpot said, I think the dependency in the framework bundle is enough (having to add one line to the composer.json file is fine I think, with a proper upgrade message ofc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't add it to the suggest section to keep BC. In 3.0 we can.
The dep in the framework bundle is not enough, only works if someone install the symfony/framework-bundle package, but if someone uses the full framework requiring symfony/symfony the dep will not be installed.

},
"replace": {
"symfony/asset": "self.version",
Expand Down Expand Up @@ -57,7 +58,6 @@
"symfony/serializer": "self.version",
"symfony/stopwatch": "self.version",
"symfony/swiftmailer-bridge": "self.version",
"symfony/templating": "self.version",
"symfony/translation": "self.version",
"symfony/twig-bridge": "self.version",
"symfony/twig-bundle": "self.version",
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Templating/.gitignore
View file
Open in desktop

This file was deleted.

83 changes: 0 additions & 83 deletions src/Symfony/Component/Templating/Asset/Package.php
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions src/Symfony/Component/Templating/Asset/PackageInterface.php
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions src/Symfony/Component/Templating/Asset/PathPackage.php
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions src/Symfony/Component/Templating/Asset/UrlPackage.php
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/Symfony/Component/Templating/CHANGELOG.md
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions src/Symfony/Component/Templating/DebuggerInterface.php
View file
Open in desktop

This file was deleted.

Loading