[Config] deprecate cannotBeEmpty() for boolean and numeric nodes #15285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 15, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
Technically, the methods won't be removed, but will throw exceptions instead. Though I think this doesn't make a different for users of the classes and they should not need to bother with internal details. That's why I chose to say that they will be removed in the deprecation messages. |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2015
…eric nodes (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [Config] deprecate cannotBeEmpty() for boolean and numeric nodes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- d4473f3 [Config] deprecate cannotBeEmpty() for boolean and numeric nodes
Merged
eriwin
pushed a commit
to waarneembemiddeling/bigregister-bundle
that referenced
this pull request
May 9, 2016
Since Symfony 3.0 the cannotBeEmpty() is removed for an integerNode. For more information see: symfony/symfony#15170 symfony/symfony#15285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.