[Config] Throw an exception when using cannotBeEmpty() with numeric or boolean nodes #16816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GuilhemN
commented
Dec 2, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16812 |
| License | MIT |
|
👍 |
|
👍, as a bug fix for me |
|
The build failure seems unrelated. |
|
@nicolas-grekas can you ping the people in charge of the |
|
👍 |
1 similar comment
|
👍 |
|
👍 (I think we accidentally just removed the methods instead of throwing the exception as it was planed initially, see #15285 (comment)). |
|
Thank you @Ener-Getick. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
…h numeric or boolean nodes (Ener-Getick) This PR was merged into the 3.0 branch. Discussion ---------- [Config] Throw an exception when using cannotBeEmpty() with numeric or boolean nodes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16812 | License | MIT Commits ------- bc20af2 [Config] Throw an exception when using cannotBeEmpty() on numeric or boolean nodes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.