[Translator][FileDumper] deprecated format method in favor of formatCatalogue. #15699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,8 @@ protected function formatCatalogue(MessageCatalogue $messages, $domain, array $o | |||
| * @param string $domain | |||
| * | |||
| * @return string representation | |||
| * | |||
| * @deprecated since version 2.8, to be removed in 3.0. Use formatCatalogue() instead. | |||
There was a problem hiding this comment.
the message should say Overwrite .... rather than Use ...
There was a problem hiding this comment.
and you should trigger a deprecation warning in the formatCatalogue of this class, telling it should be overwritten instead of overwriting format
dbf8b68 to
0ddc7b5
Compare
0ddc7b5 to
73573b6
Compare
73573b6 to
366879b
Compare
aitboudad
added a commit
that referenced
this pull request
Sep 17, 2015
…avor of formatCatalogue. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translator][FileDumper] deprecated format method in favor of formatCatalogue. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Fixed tickets | ~ | Tests pass? | yes | License | MIT We introduced `formatCatalogue` to allow using options passed to the dump method. Commits ------- 366879b [Translator][FileDumper] deprecated format method in favor of formatCatalogue.
| @@ -109,6 +111,8 @@ protected function formatCatalogue(MessageCatalogue $messages, $domain, array $o | |||
| * @param string $domain | |||
| * | |||
| * @return string representation | |||
| * | |||
| * @deprecated since version 2.8, to be removed in 3.0. Overwrite formatCatalogue() instead. | |||
| */ | |||
| abstract protected function format(MessageCatalogue $messages, $domain); | |||
There was a problem hiding this comment.
@aitboudad this method should be implemented now (throwing an exception saying it must be implemented), to allow new child classes to implement only formatCatalogue and not both methods
There was a problem hiding this comment.
see #15832 and thanks for the hint.
Tobion
added a commit
that referenced
this pull request
Sep 18, 2015
…plement only formatCatalogue (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translation][File dumper] allow new child classes to implement only formatCatalogue | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #15699 | Tests pass? | yes | License | MIT Commits ------- 5fd9f2f [Translation][File dumper] allow new child classes to implement only formatCatalogue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced
formatCatalogueto allow using options passed to the dump method.