[3.0][Security] Remove deprecated features #15899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Sep 26, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
You need to update the VoterFixture class to implement |
|
@wouterj Can you finish this PR? |
2ea3de5 to
6f9e897
Compare
|
@fabpot done. I've also removed |
|
hmm, I've not checked, but I'm pretty sure they are some tests that need to be updated, no? |
|
Indeed, found some other tests and removed them as well |
|
@wouterj Looks like |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Security] Remove deprecated features | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- c3c5989 Remove more tests 6f9e897 Remove AbstractVoter#isGranted() method 6b6de15 Removed supports{Attribute,Class}() methods
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Sep 30, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Sep 30, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
Koc
added a commit
to Koc/symfony
that referenced
this pull request
Oct 1, 2015
fabpot
added a commit
that referenced
this pull request
Oct 2, 2015
#15899) (Koc) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Security] Remove deprecated features (follow up of #15899) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15899 | License | MIT | Doc PR | - - updated UPGRADE-3.0.md - removed unused `supportsClass` methods - changed visibility of `supportsAttribute` methods from public to private, removed `inheritdoc` annotation from them because there is no definition for this methods in parent interface - removed tests for `supportsClass` and `supportsAttribute` method - removed unused mock creation Commits ------- 437398d [3.0][Security] Remove deprecated features (follow up of #15899)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.