[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8 #15929
Conversation
|
shouldn't it also be removed from implementations ? Or are the existing resources needing it ? |
|
Some tests rely on it and I don't know if users do. It only does not make sense at the interface level because different implementations returned different types of values. |
|
When the implementations are kept, the documentation would need to be updated. They use Status: Needs Work |
|
Several resources used for tests also implement getResource for no reason anymore. |
|
this branch needs to be rebased too, as it conflicts with the current state |
|
Rebased, cleaned up and fixed. |
| @@ -44,7 +44,7 @@ public function __toString() | |||
| } | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
| * @return string The file path to the resource | |||
There was a problem hiding this comment.
currently it can also return false when realpath returns an error. So I propose to throw an exception in the constructor in this case which is ok in 3.0 i guess.
There was a problem hiding this comment.
Hm, maybe. But that has nothing to do with this PR, or? Shouldn't that be a differnt PR possibly with a test?
There was a problem hiding this comment.
I'm fine with a different PR. But then the phpdoc is wrong at the moment.
|
Why does DirectoryResource not call |
|
I don't know why |
|
👍 Status: Reviewed |
|
Created #15946 for the remainder |
|
Thank you @mpdude. |
…which was deprecated in 2.8 (mpdude) This PR was squashed before being merged into the 3.0-dev branch (closes #15929). Discussion ---------- [3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Deprecated in #15719. Commits ------- 7cef180 [3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8
Deprecated in #15719.