[Security\Core] Fix test failure after sebastianbergmann/phpunit#1821 #16138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas IMO, we should refactor the tests to avoid creating mocks in the data provider. In my experience, mocks created in data providers create weird edge cases and issues. |
|
The issue with them is sebastianbergmann/phpunit#1821, which is fixed in phpunit 5.0. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 6, 2015
…/phpunit#1821 (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16112 | License | MIT | Doc PR | - See sebastianbergmann/phpunit#1821 Commits ------- 742547c [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821
|
@stof I merged this PR to get green tests back asap. Feel free to open an other PR if you want to refactor this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sebastianbergmann/phpunit#1821