[FrameworkBundle] Fix deps=low/high tests #16145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 6, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -196,8 +196,13 @@ public function testTranslator() | |||
| '->registerTranslatorConfiguration() finds Form translation resources' | |||
| ); | |||
| $ref = new \ReflectionClass('Symfony\Component\Security\Core\SecurityContext'); | |||
| $ref = dirname($ref->getFileName()); | |||
| if (!file_exists($ref.'/composer.json')) { | |||
| $this->assertFalse(file_exists($ref.'/Resources/translations/')); | |||
There was a problem hiding this comment.
This one ensures that we won't merge in Core/Resources/translations again (should be removed on 2.7)
There was a problem hiding this comment.
This test should rather be in the security component (otherwise you cannot remove this in 2.7 because of the 2.7 low deps).
And then, in 2.7+, it should be replaced by a test ensuring they are in sync (or at least than the new files don't miss any translations from the old file).
There was a problem hiding this comment.
too much crack today for me :) updated!
| @@ -89,4 +89,9 @@ public function testGetSetToken() | |||
| $context->setToken($token = $this->getMock('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')); | |||
| $this->assertSame($token, $context->getToken()); | |||
| } | |||
|
|
|||
| public function testResourcesAreNotInCore() | |||
There was a problem hiding this comment.
I would say Translations, not Resources
|
👍 Status; reviewed |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Fix deps=low/high tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 26ca3dc [FrameworkBundle] Fix deps=low/high tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.