[Security] sync translations and add a test for it #16146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 6, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15955 |
| License | MIT |
| Doc PR |
| { | ||
| $securityClass = new \ReflectionClass('Symfony\Component\Security\Core\Security'); | ||
|
|
||
| return dirname($securityClass->getFileName()).'/Resources/translations'; |
There was a problem hiding this comment.
When testing it from the Security component, I don't think there is the necessity to find the translation dir like this.
It'll always be into __DIR__.'/../Core/Resources/translations', right ?
ba07797 to
08333ec
Compare
|
I addressed the comments. |
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Security] sync translations and add a test for it | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15955 | License | MIT | Doc PR | Commits ------- 08333ec [Security] sync translations and add a test for it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.