Skip to content

[Serializer] polyfill for json_last_error_msg is in php 5.5 #16382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2015

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Oct 29, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16317
License MIT
Doc PR -

We need the polyfill for json_last_error_msg which is part of php 5.5, not 5.4.

@nicolas-grekas
Copy link
Member

👍

@Tobion Tobion merged commit fb031f1 into symfony:2.8 Oct 29, 2015
Tobion added a commit that referenced this pull request Oct 29, 2015
…5 (Tobion)

This PR was merged into the 2.8 branch.

Discussion
----------

[Serializer] polyfill for json_last_error_msg is in php 5.5

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16317
| License       | MIT
| Doc PR        | -

We need the polyfill for `json_last_error_msg` which is part of php 5.5, not 5.4.

Commits
-------

fb031f1 [Serializer] polyfill for json_last_error_msg is in php 5.5
@Tobion Tobion deleted the fix-wrong-polyfill-requirement branch October 29, 2015 14:05
fabpot added a commit that referenced this pull request May 13, 2017
…-core (BPScott)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Security] Remove polyfill-util dependancy from security-core

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Security-core no longer directly depends upon polyfill-util since #16382.

This does not change the existing dependancy tree as polyfill-util is
transitivly depended on via polyfill-php56.

Commits
-------

fb140aa Remove polyfill-util dependancy from security-core
Tobion added a commit that referenced this pull request Jan 15, 2018
…ity (thewilkybarkid)

This PR was merged into the 3.3 branch.

Discussion
----------

Remove polyfill-util dependency from fullstack and security

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | kinda
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Applies #22709 to the two higher-level packages. I've applied it to 3.3 as that's where that change was merged (though it was `master` as the time); these may actually apply earlier though?

(#16382 was mentioned and applied to 2.8, though is for the serializer which is unrelated? Should have been 3.0 when `StringUtils` was removed?)

Commits
-------

939efd5 Remove polyfill-util dependency from fullstack and security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants