Skip to content

Remove polyfill-util dependency from fullstack and security #25784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

thewilkybarkid
Copy link
Contributor

Q A
Branch? 3.3
Bug fix? kinda
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Applies #22709 to the two higher-level packages. I've applied it to 3.3 as that's where that change was merged (though it was master as the time); these may actually apply earlier though?

(#16382 was mentioned and applied to 2.8, though is for the serializer which is unrelated? Should have been 3.0 when StringUtils was removed?)

@xabbuh xabbuh added this to the 3.3 milestone Jan 15, 2018
@Tobion
Copy link
Contributor

Tobion commented Jan 15, 2018

Good catch, thanks @thewilkybarkid.

@Tobion Tobion merged commit 939efd5 into symfony:3.3 Jan 15, 2018
Tobion added a commit that referenced this pull request Jan 15, 2018
…ity (thewilkybarkid)

This PR was merged into the 3.3 branch.

Discussion
----------

Remove polyfill-util dependency from fullstack and security

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | kinda
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Applies #22709 to the two higher-level packages. I've applied it to 3.3 as that's where that change was merged (though it was `master` as the time); these may actually apply earlier though?

(#16382 was mentioned and applied to 2.8, though is for the serializer which is unrelated? Should have been 3.0 when `StringUtils` was removed?)

Commits
-------

939efd5 Remove polyfill-util dependency from fullstack and security
@thewilkybarkid thewilkybarkid deleted the polyfill-util branch January 15, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants