[SecurityBundle] Fix disabling of RoleHierarchyVoter when passing empty hierarchy #16460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +157,7 @@ private function configureDbalAclProvider(array $config, ContainerBuilder $conta | |||
| */ | |||
| private function createRoleHierarchy($config, ContainerBuilder $container) | |||
| { | |||
| if (!isset($config['role_hierarchy'])) { | |||
| if (!isset($config['role_hierarchy']) || 0 === count($config['role_hierarchy'])) { | |||
There was a problem hiding this comment.
I actually think it is always set due to the way the configuration class works
|
Is it really a bug or just a simplification? If the latter, we need to merge this into 2.8 instead. |
|
@fabpot I think we can call this a simplification. |
|
Thank you @wouterj. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role_hierarchy: ~in the config, the role hierarchy voter was still enabled. I've now changed this so that an empty hierarchy also results in disabling this voter. With an empty hierarchy, the voter behaves exactly the same as the RoleVoter, so no BC break is introduced here.