[SecurityBundle] Partial revert of #16460 #16731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 The revert in this PR completely reverts the improvement added in my PR. (I found out my test always passed for some reason) I propose to fix this in another (imo better) way: #16734 |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2015
…terJ) This PR was squashed before being merged into the 2.8 branch (closes #16734). Discussion ---------- Make sure security.role_hierarchy.roles always exists | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16731 | License | MIT | Doc PR | - Commits ------- b272ab5 Make sure security.role_hierarchy.roles always exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIng @wouterj since you proposed #16460
Tests are currently broken on 2.8 because of this.
The tests that you created are still green.