[HttpFoundation] Deprecate $deep parameter on ParameterBag #16706
Conversation
nicolas-grekas
commented
Nov 27, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| } | ||
| } | ||
| if (is_bool($filter) || !isset($filters[$filter]) || is_array($deep)) { | ||
| @trigger_error('Passing the $deep boolean as 3rd argument of the '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0.', E_USER_ERROR); |
There was a problem hiding this comment.
to pass it as last argument is also deprecated. this can be important when we add new arguments later.
There was a problem hiding this comment.
message updated, ok for you?
9d23b9b to
f4f082e
Compare
…rBag (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Deprecate $deep parameter on ParameterBag | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f4f082e [HttpFoundation] Deprecate $deep parameter on ParameterBag
|
FYI this is not documented in UPGRADE-3.0. With a possible alternative like the PropertyAccess component. |
|
@sstok we already have an issue saying that the upgrade file is incomplete |
|
#16667 found it, should we keep a list in that issue about things that are missing? (so that anyone willing can tackle them) (or is there a google docs page where this is tracked?). The documentation also still mentions the old parameter. |
|
@sstok in several places, the component changelogs are listing deprecations. This will be the easy part to synchronize (it is a matter of checking whether all changelog entries are listed). but the changelog files themselves might be incomplete. In this case, it would require checking the codebase for deprecations |