[DX][YAML] Improved Deprecation Notices #16748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 The YAML errors are indeed quite difficult to find. |
|
The Status: Needs work |
|
But in Inline::parseScalar I do not have access to the line number. I find the line number not helpful as you do not even know the file, you anyway have to grep for it. |
|
@xabbuh The ParseException already contains it in 3.0, as the parser does it with a global try/catch/rethrow |
|
Okay, so good to go? |
|
Please fix the tests |
|
Updated, buils are pending... |
|
@stof Tests passed now. |
|
Thank you @peterrehm. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [DX][YAML] Improved Deprecation Notices Show the actual invalid string for the Yaml deprecations to ease the upgrade as you can grep the strings. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Related #16745 Commits ------- 3179407 Improved error messages for Yaml Deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the actual invalid string for the Yaml deprecations to ease the upgrade as you can grep the strings.
Related #16745