Skip to content

[Form] document changes to form type interfaces #16752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] document changes to form type interfaces #16752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions UPGRADE-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ UPGRADE FROM 2.x to 3.0

### Form

* The `getBlockPrefix()` method was added to the `FormTypeInterface` in replacement of
the `getName()` method which has been has been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the sentence is rather as follows:

The `FormTypeInterface::getName()` method has been removed in favor of 
the `FormTypeInterface::getBlockPrefix()` method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogizanagi the BC break in 3.0 is that the method was added in the interface

* The `configureOptions()` method was added to the `FormTypeInterface` in replacement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to show the different signature to reflect the change from OptionsResolverInterface to OptionsResolver

of the `setDefaultOptions()` method which has been removed.
* The `getBlockPrefix()` method was added to the `ResolvedFormTypeInterface` in
replacement of the `getName()` method which has been has been removed.
* The option "precision" was renamed to "scale".

Before:
Expand Down