[Security] These interface allways send deprecated because of wrong inheritance #16775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xkobal
commented
Dec 1, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16643 |
| License | MIT |
| Doc PR |
(cherry picked from commit 02fe171)
|
Seems related to #16643 |
|
Yes this is the same problem, I haven't seen the issue |
|
Broken tests doesn't seems to come from my PR :-/ |
|
The inheritance is done the right way to preserve BC. What should be fixed is that the DebugClassLoader should not trigger a warning for this particular case. |
|
@nicolas-grekas please check this case for the DebugClassLoader |
|
Me or anyone else :-) |
|
I just implemented it in #17320. |
|
Closing in favor of #17320 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 12, 2016
…terfaces (peterrehm) This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Fixed erroneous deprecation notice for extended Interfaces | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16643, #16775 | License | MIT | Doc PR | - Replaces #16775. Commits ------- 5f4e968 Fixed erroneous deprecation notice for extended Interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.