Skip to content

[Form] Make tests compatible with master #17469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

paradajozsef
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

I wrote tests in this PR: #17406 which was compatible only with 2.7. @xabbuh fixed it in 2.8 and 3.0 here: #17463. And this PR fixes deprecated notices in master.

Kind of an unfortunate situation...

@paradajozsef
Copy link
Contributor Author

Travis failed on PHP7, but seems unrelated:
https://travis-ci.org/symfony/symfony/jobs/103792342#L151

@fabpot
Copy link
Member

fabpot commented Jan 21, 2016

Thank you @paradajozsef.

@fabpot fabpot merged commit 96e40b2 into symfony:master Jan 21, 2016
fabpot added a commit that referenced this pull request Jan 21, 2016
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Form] Make tests compatible with master

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I wrote tests in this PR: #17406 which was compatible only with 2.7. @xabbuh fixed it in 2.8 and 3.0 here: #17463. And this PR fixes deprecated notices in master.

Kind of an unfortunate situation...

Commits
-------

96e40b2 Fix unit tests in master
@paradajozsef paradajozsef deleted the fix-form-unit-tests branch January 21, 2016 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants