[DependencyInjection] resolve aliases in factories #17554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 27, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | FriendsOfSymfony/FOSUserBundle#2048 |
| License | MIT |
| Doc PR |
This was referenced Jan 27, 2016
| private function processFactory($factory) | ||
| { | ||
| if (null === $factory || !is_array($factory) || !$factory[0] instanceof Reference) { | ||
| return; |
33e0669 to
fde10e7
Compare
| $defId = $this->getDefinitionId($id = (string) $factory[0]); | ||
|
|
||
| if ($defId !== $id) { | ||
| $factory[0] = new Reference($defId, $factory[0]->getInvalidBehavior(), $factory[0]->isStrict()); |
There was a problem hiding this comment.
note that this line will need changes when merging into 2.8 (and then again in 3.0) due to changes to isStrict
|
👍 |
|
Status: reviewed |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] resolve aliases in factories | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | FriendsOfSymfony/FOSUserBundle#2048 | License | MIT | Doc PR | Commits ------- fde10e7 resolve aliases in factories
|
@xabbuh Can I let you merge 2.3 into 2.7, 2.7 into 2.8, and 2.8 into 3.0? This should be easy as I've done the merge not too long ago. |
|
@fabpot sure, did so |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.