Fix decoration of private services #17649
Conversation
|
Please describe the issue you are facing. This change looks wrong to me. When decorating a private service, the service defined for this id must stay private. |
| $container->compile(); | ||
|
|
||
| try { | ||
| $container->getAlias('foo'); |
There was a problem hiding this comment.
getting aliases after compilation does not make sense. getAlias is not a runtime usage of the container (it is not part of the ContainerInterface).
So this test does not cover a supported usage of the component.
|
@stof currently it's not possible to decorate a private factory service: services:
foo_factory:
class: 'AppBundle\FooFactory'
public: false
foo_factory_decorator:
class: 'AppBundle\FooFactoryDecorator'
public: false
arguments: [ '@foo_factory_decorator.inner' ]
decorates: 'foo_factory'
foo:
class: 'AppBundle\Foo'
factory: [ '@foo_factory', 'createFoo' ]The decorator pass create a private alias and it is never made public, and is then removed. This "fix" is naive but works, however it probably create some side effects. |
|
We should probably be checked if an alias is used as a factory in |
|
@dunglas there is currently a bug in stable versions with using private aliases as a factory service. This is totally unrelated to the usage of decoration (it happens with any private alias) and has already been fixed in all maintained branches 1 week ago (the issue has been detected by a change in FOSUserBundle). |
|
OK, so I'm closing this PR as the actual issue is already fixed in dev versions |
This PR allow to decorate private service.
The alternative is to not remove private aliases which are not use elsewhere.
What do you think ?