[Cache] Add a Chain adapter #17556
Closed
[Cache] Add a Chain adapter #17556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
So every PSR-6 cache implementation must implement its own ChainCache because each one can only work with his own CacheItem? |
|
You can use an external CacheItemPool if you wrap it with the ProxyApadpter before adding it to the chain. |
|
Btw it is possible to automatically wrap external pools in the constructor. I'll update the PR. |
| */ | ||
| public function __construct(array $adapters) | ||
| { | ||
| if (2 > count($adapters)) { |
There was a problem hiding this comment.
Why? When making this configurable by the user, you might end up with just one adapter, which is fine. I would change the check to 1 < count().
|
Status: needs work |
| class ChainAdapterTest extends CachePoolTest | ||
| { | ||
| protected $skippedTests = array( | ||
| 'testDeferredSaveWithoutCommit' => 'Assumes a shared cache which ArrayAdapter is not.', |
There was a problem hiding this comment.
I agree, same for the two others below, there are not needed anymore I think
|
Replaced by #18215 |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Add a Chain adapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #17556 | License | MIT | Doc PR | - Made in coordination with @dunglas Commits ------- 68d9cea [Cache] Optimize Chain adapter ebdcd16 [Cache] Add a Chain adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to chain adapters. Replaces #17452.