[2.7] Fix tests #17582
Closed
[2.7] Fix tests #17582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paradajozsef
commented
Jan 27, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | Let's see Travis results |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
Other tests are failing too. (They didn't show until this was fixed) In progress.. Status: Needs Work |
| @@ -548,7 +548,7 @@ private function assertUrlPackage(ContainerBuilder $container, DefinitionDecorat | |||
| private function assertVersionStrategy(ContainerBuilder $container, Reference $reference, $version, $format) | |||
| { | |||
| $versionStrategy = $container->getDefinition($reference); | |||
| if (null === $version) { | |||
| if (null === $version || !$versionStrategy instanceof DefinitionDecorator) { | |||
There was a problem hiding this comment.
When is $versionStrategy allowed to be an instance of DefinitionDecorator while $version is null?
There was a problem hiding this comment.
You are right, this fix is wrong.
|
@xabbuh Could you take a look please? Only 5.3 failes now on Travis but for some other reason, not related to tests: Status: Needs Review |
| @@ -21,7 +21,7 @@ class LegacyApcUniversalClassLoaderTest extends \PHPUnit_Framework_TestCase | |||
| protected function setUp() | |||
| { | |||
| if (ini_get('apc.enabled') && ini_get('apc.enable_cli')) { | |||
| apcu_clear_cache('user'); | |||
| apcu_clear_cache(); | |||
| } else { | |||
| $this->markTestSkipped('APC is not enabled.'); | |||
| if (null === $version) { | ||
| $this->assertEquals('assets.empty_version_strategy', (string) $reference); | ||
| } else { | ||
| if ($version && $versionStrategy instanceof DefinitionDecorator) { |
|
After #17605 merged, this PR fixes the remaining failing tests. |
|
Thank you @paradajozsef. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2016
This PR was squashed before being merged into the 2.7 branch (closes #17582). Discussion ---------- [2.7] Fix tests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Let's see Travis results | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- c8e1384 [2.7] Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.