[FrameworkBundle] remove default null value for asset version #17605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `null` as the version of a package means that it uses the empty version strategy. However, omitting the `version` option entirely was meant to fall back to the default version strategy. This is not possible when the default version value is `null` as there is no way to remove it.
|
There are more broken tests in the FrameworkBundle which are not related to the Asset component. :( |
Closed
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2016
…ion (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] remove default null value for asset version | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Setting `null` as the version of a package means that it uses the empty version strategy. However, omitting the `version` option entirely was meant to fall back to the default version strategy. This is not possible when the default version value is `null` as there is no way to remove it. Commits ------- 25f735f remove default null value for asset version
Merged
|
@xabbuh sorry for late reply, I miss this issue My original commit was related to https://github.com/symfony/symfony/pull/16511/files#r50645726. Seems if tests working and "fall back to the default version strategy" is covered, than your fix right, but on first look seems it is broke BC. |
|
@ewgRa I'll happily look if we need to fix anything if you happen to find a configuration that used to work before and now doesn't work anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
nullas the version of a package means that it uses the emptyversion strategy. However, omitting the
versionoption entirely wasmeant to fall back to the default version strategy. This is not possible
when the default version value is
nullas there is no way to removeit.