[2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType #17798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok tests are passing, failure seems not related. |
2346190 to
ab79ad5
Compare
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 22, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 22, 2016
1 task
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 22, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 22, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 22, 2016
1 task
|
👍 |
| if (null === $label) { | ||
| // If the labels are null, use the original choice key by default | ||
| $label = (string) $key; | ||
| } elseif (false !== $label) { |
There was a problem hiding this comment.
In order to document better what this code does, could you please add a comment here about the false value? Something like:
// If "choice_label" is set to false and "expanded" is true, the value false
// should be passed on to the "label" option of the checkboxes/radio buttons|
👍 apart from my comment |
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Feb 26, 2016
When `ChoiceType`is expanded, `choice_label` option can be `false` or return `false` for one or more choices by a callable.
|
Fixed, rebased and squashed. ping @fabpot |
|
Sorry, rebased on 2.8. I'm fixing it. |
When `ChoiceType`is expanded, `choice_label` option can be `false` or return `false` for one or more choices by a callable.
|
Ok now just waiting for the green :) |
|
👍 Status: Reviewed |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
…n to be 'false' in ChoiceType (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17773 | License | MIT | Doc PR | symfony/symfony-docs#6282 - [x] Make tests pass - [x] Adress a doc PR - [x] Replace alias by FQCN in tests for 2.8, see #17890 - [x] Remove `choices_as_values` in tests for 3.0, see #17891 Commits ------- 017e1d9 bug #17798 [Form] allow `choice_label` option to be `false`
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
* 2.7: bug #17798 [Form] allow `choice_label` option to be `false`
fabpot
pushed a commit
that referenced
this pull request
Feb 28, 2016
fabpot
pushed a commit
that referenced
this pull request
Feb 28, 2016
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
* 3.0: #17676 - making the proxy instantiation compatible with ProxyManager 2.x by detecting proxy features #17676 - making the proxy instantiation compatible with ProxyManager 2.x by detecting proxy features Fix bug when using an private aliased factory service [Form] fix tests added by #17798 by removing `choices_as_values` [Form] fix FQCN in tests added by #17798 [DependencyInjection] Remove unused parameter of private property bug #17798 [Form] allow `choice_label` option to be `false` [Form] fix tests added by #17760 with FQCN ChoiceFormField of type "select" could be "disabled" Update contributing docs [Console] Fix escaping of trailing backslashes Fix constraint validator alias being required [DependencyInjection] Simplified code in AutowirePass [ci] clone with depth=1 to kill push-forced PRs Add check on If-Range header
This was referenced Feb 28, 2016
Merged
Merged
Merged
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Mar 1, 2016
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
…me (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- [From] minor fix tests added by #17798 for bootstrap theme | Q | A | ------------- | --- | Branch | 2.7+ | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- ee5b119 [From] minor fix tests added by #17798 for bootstrap theme
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
* 2.7: [From] minor fix tests added by #17798 for bootstrap theme
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
* 2.8: fix debug toolbar rendering by removing inadvertently added links [Form] minor fix tests of Bootstrap layout [From] minor fix tests added by #17798 for bootstrap theme simplified code Allow variadic controller parameters to be resolved.
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
* 3.0: fix debug toolbar rendering by removing inadvertently added links [Form] minor fix tests of Bootstrap layout [From] minor fix tests added by #17798 for bootstrap theme simplified code Allow variadic controller parameters to be resolved.
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 6, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Form] fix `choice_label` values | Q | A | ------------- | --- | Doc fix? | yes | New docs? | kind of | Applies to | 2.7+ | Fixed tickets | n/a This PR is a complement of symfony/symfony#17798, which allows handling `false` as `choice_label` value in `ChoiceType` and its inheritance. Not sure about the phrasing but this is the idea, suggestions are welcome ! Commits ------- 73f1935 [Form] fix `choice_label` values
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.8: fix debug toolbar rendering by removing inadvertently added links [Form] minor fix tests of Bootstrap layout [From] minor fix tests added by symfony#17798 for bootstrap theme simplified code Allow variadic controller parameters to be resolved.
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 3.0: fix debug toolbar rendering by removing inadvertently added links [Form] minor fix tests of Bootstrap layout [From] minor fix tests added by symfony#17798 for bootstrap theme simplified code Allow variadic controller parameters to be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
choices_as_valuesin tests for 3.0, see [3.0] [Form] fix tests added by #17798 by removingchoices_as_values#17891