[From] minor fix tests added by #17798 for bootstrap theme #17973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Mar 1, 2016
| Q | A |
|---|---|
| Branch | 2.7+ |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
|
ping @symfony/mergers |
|
👍 But some tests still fail, probably because of what @xabbuh explained here: #17568 (comment) |
|
Yes, I still don't understand the reason, but it makes TwigBridge difficult to debug. |
|
The Status: Needs work |
|
Ok I keep investigating then. |
|
@xabbuh, It's not the first PR where I notice this, travis builds for php 5.6 and php 7 run the tests without taking into account the PR commits. I don't see what I can do... ??? |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
…me (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- [From] minor fix tests added by #17798 for bootstrap theme | Q | A | ------------- | --- | Branch | 2.7+ | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- ee5b119 [From] minor fix tests added by #17798 for bootstrap theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.