[Ldap] Add forward compatibility layer #18076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the tests fail for an unrelated reason. |
|
Don't you also have to update some dep versions in some composer.json files? |
|
This will be done in the 3.0 and 2.8 branches. |
|
@csarrazi can you open the sibling PR you're thinking about please? |
|
Sure. Will do later today. |
|
Rebased PR |
|
AppVeyor builds fail because of an issue in the Console component (unrelated to this PR). Related PR #18201 should be merged afterward, to release the version requirement on the |
|
Thank you @csarrazi. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 16, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Ldap] Add forward compatibility layer | Q | A | ------------- | --- | Branch | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR adds forward-compatibility for the use of the Ldap component within the Security component. Indeed, currently, if one uses the `Symfony\Component\Ldap\LdapClient` class and upgrades to the `master` branch of `symfony/symfony`, the Security component will break as the class does not implement `LdapInterface`. This PR fixes this. This means that from now on, the `master` branch of the Ldap component should be compatible with all versions of the Security component. The 2.8/3.0 Security component should be compatible with all versions of the Ldap component, and the 3.1 Security component should be compatible with versions 3.1 onwards of the Ldap component. Commits ------- 97d9cee Improved BC layer for the Ldap component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds forward-compatibility for the use of the Ldap component within the Security component. Indeed, currently, if one uses the
Symfony\Component\Ldap\LdapClientclass and upgrades to themasterbranch ofsymfony/symfony, the Security component will break as the class does not implementLdapInterface.This PR fixes this.
This means that from now on, the
masterbranch of the Ldap component should be compatible with all versions of the Security component. The 2.8/3.0 Security component should be compatible with all versions of the Ldap component, and the 3.1 Security component should be compatible with versions 3.1 onwards of the Ldap component.