[HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5 #19048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 14, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -224,11 +224,11 @@ private function getMergeSql() | |||
| { | |||
| $platform = $this->con->getDatabasePlatform()->getName(); | |||
|
|
|||
| switch ($platform) { | |||
| case 'mysql': | |||
| switch (true) { | |||
There was a problem hiding this comment.
bonus fix: https://github.com/symfony/symfony/pull/19048/files#diff-e6a5cc5d66fa241233b3314fcd49f228R236 is dead code today
|
👍 |
|
Please update https://github.com/nicolas-grekas/symfony/blob/0b5b693f19915a263630ea85bc3cce208f9bad9d/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php#L350 to say "like in Postgres < 9.5" to avoid confusion. Apart from that 👍 |
|
updated |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2016
…= 9.5 (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9569c74 [HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5
Merged
This was referenced Jun 30, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jul 18, 2016
…(stof) This PR was merged into the 2.7 branch. Discussion ---------- Fix the DBAL session handler version check for Postgresql | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a #19048 broken the DBAL session handler when using Postgresql by using method which does not exist on the main DBAL Connection class. Commits ------- e98c584 Fix the DBAL session handler version check for Postgresql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.