[VarDumper] Get dump as string with $dumper->dump(..., true);
#19755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
More than already done here? |
|
Looks good! I also wondered if these 4 lines of boilerplate code can be reduced as well? I've had to use it in a couple places in that PR. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 28, 2016
…, true);` (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Get dump as string with `$dumper->dump(..., true);` | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | License | MIT ping @lyrixx @wouterj since you expressed interest in boilerplate reduction around this in the past :) Commits ------- 4be9776 [VarDumper] Get dump as string with `$dumper->dump(..., true);`
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @lyrixx @wouterj since you expressed interest in boilerplate reduction around this in the past :)