Skip to content

[WebProfilerBundle] Simplify WebProfilerExtension #20038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Sep 23, 2016

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? wait for travis
Fixed tickets follow up of #19755
License MIT
Doc PR -

@nicolas-grekas am I wrong or not?

@Koc Koc changed the title Simplify WebProfilerExtension [WebProfilerBundle] Simplify WebProfilerExtension Sep 23, 2016
@nicolas-grekas
Copy link
Member

The script and style tags will be repeated for each and every dump, whereas the current logic manages a state to prevent it.

@Koc
Copy link
Contributor Author

Koc commented Sep 23, 2016

indeed, thanx

@Koc Koc closed this Sep 23, 2016
@Koc Koc deleted the simplify-webprofiler branch July 23, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants