Skip to content

[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge #19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2016
Merged

[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge #19926

merged 1 commit into from
Sep 13, 2016

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Sep 13, 2016

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19921
License MIT
Doc PR -
#19325 relied on a wrong count of messages, which was fixed by #19878.

Additionally, the getContainer() method on the master branch expect messages to be indexed by domain.

@nicolas-grekas
Copy link
Member

So, only an issue in tests? Shouldn't this be applied on previous branches? Any potential BC break spotted by this failure?

@jakzal
Copy link
Contributor Author

jakzal commented Sep 13, 2016

Not sure why PHP 7 builds are failing here:

Could not load package symfony/framework-bundle in file:///home/travis/build/symfony/symfony: [UnexpectedValueException] Invalid version string "master.999"

@jakzal
Copy link
Contributor Author

jakzal commented Sep 13, 2016

So, only an issue in tests? Shouldn't this be applied on previous branches? Any potential BC break spotted by this failure?

Yes, only issue with tests. It's a result of changes made on master.

#19325 relied on a wrong count of messages, which was fixed by #19878.

The #19325 test is only present in the master branch, so it wasn't a problem until #19878 was merged to master.

Additionally, the getContainer() method on the master branch expect messages to be indexed by domain.

Again, this is only on master.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 13, 2016 •
edited
Loading

Could not load package symfony/framework-bundle

I'll look at this asap, should be related to the changes I made yesterday, that were far from easy :)

@nicolas-grekas
Copy link
Member

Thank you @jakzal.

@nicolas-grekas nicolas-grekas merged commit d093c40 into symfony:master Sep 13, 2016
nicolas-grekas added a commit that referenced this pull request Sep 13, 2016
@nicolas-grekas
bug #19926 [FrameworkBundle] Fix TranslationUpdateCommand tests after…
0954f3d 
… a merge (jakzal)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19921
| License       | MIT
| Doc PR        | -

#19325 relied on a wrong count of messages, which was fixed by #19878.
Additionally, the `getContainer()` method on the master branch expect messages to be indexed by domain.

Commits
-------

d093c40 [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge
@jakzal jakzal deleted the translation-update-tests-fix branch September 13, 2016 12:03
@fabpot fabpot mentioned this pull request Oct 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakzal @nicolas-grekas @carsonbot