Skip to content

[Validator] Update IpValidatorTest data set with a valid reserved IP #19928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Sep 13, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19885
License MIT
Doc PR -

The validator uses PHP filter which was recently fixed (see https://bugs.php.net/bug.php?id=72972).

@nicolas-grekas
Copy link
Member

Thank you @jakzal.

@nicolas-grekas nicolas-grekas merged commit 86a151c into symfony:2.7 Sep 13, 2016
nicolas-grekas added a commit that referenced this pull request Sep 13, 2016
…eserved IP (jakzal)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] Update IpValidatorTest data set with a valid reserved IP

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19885
| License       | MIT
| Doc PR        | -

The validator uses PHP filter which was recently fixed (see https://bugs.php.net/bug.php?id=72972).

Commits
-------

86a151c [Validator] Update IpValidatorTest data set with a valid reserved IP
@jakzal jakzal deleted the ip-validator-test-reserved-ranges branch September 13, 2016 11:52
This was referenced Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants