👍

Does it fix a bug? I fail to see how this is important to change; we can probably find such other examples in the codebase.

What is the policy? I can resubmit this for master if that's better. Or I
can make it part of #20217 if that's fine.

On Fri, 14 Oct 2016, 22:26 Fabien Potencier, notifications@github.com
wrote:

Does it fix a bug? I fail to see how this is important to change; we can
probably find such other examples in the codebase.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20216 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhf67nUMfnONy4L8_bvPKVrs8Sg8I-0ks5qz5EugaJpZM4KWoXQ
.

@teohhanhui I'm not against this change, but this adds a lot of overhead for the core team for no actual benefit (reviewing the change to be sure it's safe, merging the PR, possible conflicts when merging old branches to newer ones, ...). So, I prefer to avoid PRs that don't really solve any issue. Doing this as part of #20217 is indeed an option, but honestly, I don't see the need for this change.

Sometimes it's just hard to resist the urge of wanting to fix minor code
quality issues when you accidentally see it when working on something else.

So, just for the record, should minor code quality improvement PRs like
this generally be avoided? If that's the team's decision I shall of course
abide by it.

On Fri, 14 Oct 2016, 23:13 Fabien Potencier, notifications@github.com
wrote:

@teohhanhui https://github.com/teohhanhui I'm not against this change,
but this adds a lot of overhead for the core team for no actual benefit
(reviewing the change to be sure it's safe, merging the PR, possible
conflicts when merging old branches to newer ones, ...). So, I prefer to
avoid PRs that don't really solve any issue. Doing this as part of #20217
#20217 is indeed an option, but
honestly, I don't see the need for this change.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#20216 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhf6xgl4iXJBuPrrBvo0L6RHUbZlFbyks5qz5wugaJpZM4KWoXQ
.

The issue is that we have some experience in breaking Symfony by merging apparently minor things... So we learned to be careful...

Should I close this?