[Serializer] Support specifying format for DateTimeNormalizer::denormalize #20217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teohhanhui
commented
Oct 14, 2016
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | symfony/symfony-docs#7063 |
181bb45 to
54d7b75
Compare
|
👍, can you also open a doc PR? |
|
I forgot to add test for invalid cases. |
Where should I add it? I see that the /cc @weaverryan |
|
@teohhanhui I think your addition would fit there quite well (as long as there is no dedicated chapter about all the normalizers we have) |
This was referenced Oct 14, 2016
|
Documentation added. |
54d7b75 to
a72d997
Compare
|
Test case added for denormalize format mismatch. |
a72d997 to
ff23924
Compare
|
Thank you @teohhanhui. |
fabpot
added a commit
that referenced
this pull request
Oct 17, 2016
…malizer::denormalize (teohhanhui) This PR was merged into the 3.2-dev branch. Discussion ---------- [Serializer] Support specifying format for DateTimeNormalizer::denormalize | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#7063 Commits ------- ff23924 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
Merged
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 10, 2016
…alizer::denormalize (teohhanhui) This PR was merged into the master branch. Discussion ---------- [Serializer] Support specifying format for DateTimeNormalizer::denormalize Waiting for symfony/symfony#20217 to be merged. Commits ------- 57bf969 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.