[Yaml] Fix 7.1 compat #20291
Merged
[Yaml] Fix 7.1 compat #20291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff7f408 to
89b78f2
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Yaml] Fix 7.1 compat | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Should make CI green again with PHP 7.1 RC4. Commits ------- 89b78f2 [Yaml] Fix 7.1 compat
Merged
stof
reviewed
Nov 3, 2016
| @@ -507,17 +507,17 @@ public function testParseTimestampAsDateTimeObject($yaml, $year, $month, $day, $ | |||
| $expected = new \DateTime($yaml); | |||
| $expected->setTimeZone(new \DateTimeZone('UTC')); | |||
| $expected->setDate($year, $month, $day); | |||
| $expected->setTime($hour, $minute, $second); | |||
| @$expected->setTime($hour, $minute, $second, 1000000 * ($second - (int) $second)); | |||
There was a problem hiding this comment.
Because the method takes 3 args before 7.1, and 4 since 7.1 ($microseconds)
There was a problem hiding this comment.
Why not making the call dependent on the executed PHP version then?
There was a problem hiding this comment.
I had HHVM in mind, I don't know if the version check will be valid (now or later when they'll implement this). Do as you prefer :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make CI green again with PHP 7.1 RC4.