[Yaml] set arguments depending on the PHP version #20408
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 4, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
|
So, regarding #20291 (comment) |
|
Yeah, I think it doesn't hurt to wait what HHVM will do in the future. We can still adapt the test then if needed. |
linaori
reviewed
Nov 4, 2016
| @@ -507,7 +507,12 @@ public function testParseTimestampAsDateTimeObject($yaml, $year, $month, $day, $ | |||
| $expected = new \DateTime($yaml); | |||
| $expected->setTimeZone(new \DateTimeZone('UTC')); | |||
| $expected->setDate($year, $month, $day); | |||
| @$expected->setTime($hour, $minute, $second, 1000000 * ($second - (int) $second)); | |||
|
|
|||
| if (PHP_VERSION_ID >= 70100) { | |||
There was a problem hiding this comment.
Will this work for different HHVM versions?
There was a problem hiding this comment.
Depends on which PHP version they claim to be compatible with.
There was a problem hiding this comment.
I got recommended to do a feature check where possible instead of a version check. Not sure if this is actually possible without reflection
There was a problem hiding this comment.
This is a test case, we don't care...
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Yaml] set arguments depending on the PHP version | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- ad54d83 [Yaml] set arguments depending on the PHP version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.