[TwigBridge] Handle form label attributes like others #20365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something wrong happen with PR title |
ro0NL
commented
Oct 30, 2016
| @@ -1,10 +1,2 @@ | |||
| <?php if (!empty($id)): ?>id="<?php echo $view->escape($id) ?>" <?php endif ?> | |||
| <?php foreach ($attr as $k => $v): ?> | |||
| <?php if (in_array($v, array('placeholder', 'title'), true)): ?> | |||
| @@ -1,10 +1,2 @@ | |||
| id="<?php echo $view->escape($id) ?>" name="<?php echo $view->escape($full_name) ?>" <?php if ($disabled): ?>disabled="disabled" <?php endif ?> | |||
| <?php foreach ($attr as $k => $v): ?> | |||
| <?php if (in_array($v, array('placeholder', 'title'), true)): ?> | |||
|
👍 |
|
@fabpot any chance to get this on the 3.2 train? It allows the To clarify this is consistent with |
|
There will be 3.2.1 after 3.2.0 :) |
|
That is true 👍 the RC release triggered me that maybe this was forgotten / overlooked at 👼 |
|
We work around it till 3.3 then :) the 2 bugs are real though.. but i should separate them for 2.7 i just realized. 👍 |
stof
reviewed
Dec 15, 2016
| @@ -242,7 +242,7 @@ | |||
| {% set label = name|humanize %} | |||
| {%- endif -%} | |||
| {%- endif -%} | |||
| <label{% for attrname, attrvalue in label_attr %} {{ attrname }}="{{ attrvalue }}"{% endfor %}>{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}</label> | |||
| <label{% if label_attr %} {% set attr = label_attr %}{{ block('attributes') }}{% endif %}>{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}</label> | |||
There was a problem hiding this comment.
use {% with %} around the block rendering instead of assigning label_attr to attr, which swallows the original attr variable and could cause issues
fabpot
added a commit
that referenced
this pull request
Dec 17, 2016
…ttributes (ro0NL) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix PHP form templates on translatable attributes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20365 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Separated from #20365 Commits ------- 10806e0 [FrameworkBundle] Fix PHP form templates on translatable attributes
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Dec 17, 2016
…ttributes (ro0NL) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix PHP form templates on translatable attributes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#20365 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Separated from #20365 Commits ------- 10806e0 [FrameworkBundle] Fix PHP form templates on translatable attributes
| @@ -1 +1,9 @@ | |||
| <?php echo $view['form']->block($form, 'widget_attributes') ?> | |||
| <?php foreach ($attr as $k => $v): ?> | |||
| <?php if (in_array($k, array('placeholder', 'title'), true)): ?> | |||
There was a problem hiding this comment.
I think it's worth doing a micro optim here and turn this into:
if ('placeholder' === $k || 'title' === $k):
| <?php foreach ($attr as $k => $v): ?> | ||
| <?php if (in_array($k, array('placeholder', 'title'), true)): ?> | ||
| <?php printf('%s="%s" ', $view->escape($k), $view->escape(false !== $translation_domain ? $view['translator']->trans($v, array(), $translation_domain) : $v)) ?> | ||
| <?php elseif ($v === true): ?> |
|
Updated. I qualify it a feature, not a bug. |
|
Thank you @ro0NL. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2017
…ributes (craue) This PR was merged into the 3.3 branch. Discussion ---------- [Form][3.3] avoid double blanks while rendering form attributes | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | kind of | New feature? | no | BC breaks? | no (rather reverts one) | Deprecations? | no | Tests pass? | we'll see | Fixed tickets | -- | License | MIT | Doc PR | -- This fix avoids the double blanks introduced by #20365 when using the Twig template. The `attributes` block already renders one blank before each attribute, so there's no need to add another one prior to calling the block. Commits ------- a9c11c9 avoid double blanks while rendering form attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML for rendering attributes is duplicated in multiple blocks, making it error prone/hard to maintain.
Next, the label attributes followed a different approach. Imo. all should follow the same base rendering, showing the above is actually an issue.