[Form][3.3] avoid double blanks while rendering form attributes #22845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was actually already the case before #20365, i preserved it. But the change makes sense i guess (not sure what we care about; browsers dont care right?) |
|
@ro0NL, you're right. The blanks were there before, but not in 3.2. |
OskarStark
approved these changes
May 22, 2017
ro0NL
approved these changes
May 22, 2017
|
Thank you @craue. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2017
…ributes (craue) This PR was merged into the 3.3 branch. Discussion ---------- [Form][3.3] avoid double blanks while rendering form attributes | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | kind of | New feature? | no | BC breaks? | no (rather reverts one) | Deprecations? | no | Tests pass? | we'll see | Fixed tickets | -- | License | MIT | Doc PR | -- This fix avoids the double blanks introduced by #20365 when using the Twig template. The `attributes` block already renders one blank before each attribute, so there's no need to add another one prior to calling the block. Commits ------- a9c11c9 avoid double blanks while rendering form attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix avoids the double blanks introduced by #20365 when using the Twig template. The
attributesblock already renders one blank before each attribute, so there's no need to add another one prior to calling the block.