bumped min version of Twig to 1.28 #20484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Nov 10, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | see twigphp/Twig#2236 |
| License | MIT |
| Doc PR | n/a |
81a69f8 to
418c04d
Compare
|
What about using this great feature in Form, the component that needs it most? They even define a method called renderBlock() |
stof
reviewed
Nov 11, 2016
| * @return array | ||
| * @return Twig_Template[] | ||
| * | ||
| * @deprecated not used anymore internally |
There was a problem hiding this comment.
shouldn't it throw a deprecation warning ?
There was a problem hiding this comment.
Agreed, but not in Symfony 2.7. This must be added after merging this to master.
There was a problem hiding this comment.
Agreed with @xabbuh, but this class should probably be marked as being internal as well in master.
xabbuh
reviewed
Nov 11, 2016
| @@ -200,7 +200,7 @@ public function toolbarAction(Request $request, $token) | |||
| return new Response($this->twig->render('@WebProfiler/Profiler/toolbar.html.twig', array( | |||
| 'position' => $position, | |||
| 'profile' => $profile, | |||
| 'templates' => $this->getTemplateManager()->getTemplates($profile), | |||
| 'templates' => $this->getTemplateManager()->getNames($profile), | |||
There was a problem hiding this comment.
getNames() must become public then
5c8bc22 to
73e1c06
Compare
|
@javiereguiluz Unfortunately the logic in the Form integration is complex and cannot use this technique as we are manually passing blocks to |
73e1c06 to
b8f7614
Compare
|
Updated based on the latest changes for Twig 1.28. |
|
👍 Status: Reviewed |
fabpot
added a commit
that referenced
this pull request
Nov 16, 2016
This PR was merged into the 2.7 branch. Discussion ---------- bumped min version of Twig to 1.28 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | see twigphp/Twig#2236 | License | MIT | Doc PR | n/a Commits ------- b8f7614 bumped min version of Twig to 1.28
Merged
This was referenced Nov 21, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
…etTemplates() (maidmaid) This PR was merged into the 4.0-dev branch. Discussion ---------- [WebProfilerBundle] Remove deprecated TemplateManager::getTemplates() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20484 | License | MIT | Doc PR | / Commits ------- f8be69d Remove TemplateManager::getTemplates()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.