[Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace #20616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5609c7 to
5b47181
Compare
nicolas-grekas
commented
Nov 24, 2016
| if ($container->hasParameter('cache.prefix.seed')) { | ||
| $seed = '.'.$container->getParameterBag()->resolveValue($container->getParameter('cache.prefix.seed')); | ||
| } elseif ($container->getParameter('kernel.debug')) { | ||
| $seed = '_'.$container->getParameter('kernel.root_dir'); |
There was a problem hiding this comment.
What do you think about reintroducing kernel.root_dir but only when kernel.debug is true, so that locally running apps have separate cache namespaces by default?
There was a problem hiding this comment.
I am not convinced that this is a good idea as it will force developers you deploy more than one application to the same server that share the same cache backend to always configure the cache.prefix.seed option.
There was a problem hiding this comment.
Agreed. I updated the code to use cache.prefix.seed when available, or kernel.root_dir as fallback. Looks better to me also.
|
Ping @symfony/deciders , we need to make a decision on this one before the end of the week for 3.2 to be ready (2/3). |
5b47181 to
2ad870d
Compare
|
👍 |
2575d74 to
3f3733b
Compare
3f3733b to
5e3cbec
Compare
|
👍 Status: Reviewed |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 25, 2016
…rating cache namespace (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Exactly the same issue as in #20610, but for Doctrine ORM's cache: > That's a design issue: using root_dir as discriminant doesn't work with blue/green deployment strategies, and doesn't prevent collision when different apps are deployed in the same path while sharing the same cache backend. Commits ------- 5e3cbec [Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace
This was referenced Nov 25, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly the same issue as in #20610, but for Doctrine ORM's cache: