Skip to content

[ClassLoader] Deprecate Apc/WinCache/Xcache class loaders #20777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

See composer/composer#5559

@stof
Copy link
Member

stof commented Dec 6, 2016

should we also deprecate WinCacheClassLoader and XcacheClassLoader providing similar wrappers with other storages ?

Btw, if we deprecate these caching loaders, and we deprecate the ClassCollectionLoader, the component will only contain the basic PSR-0, PSR-4 and classmap loaders, which are all useless when using composer. So we may want to deprecate the whole component instead.

@nicolas-grekas nicolas-grekas changed the title [ClassLoader] Deprecate ApcClassLoader [ClassLoader] Deprecate Apc/WinCache/Xcache class loaders Dec 6, 2016
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Dec 6, 2016

@stof I added WinCache and Xcache to this PR. I agree with you about deprecating the component. Should be done in another PR (esp. HttpKernel\Client is using the component right now, it needs some work to be freed from it).

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Dec 6, 2016
@fabpot
Copy link
Member

fabpot commented Dec 6, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit fa36e1d into symfony:master Dec 6, 2016
fabpot added a commit that referenced this pull request Dec 6, 2016
…ers (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[ClassLoader] Deprecate Apc/WinCache/Xcache class loaders

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See composer/composer#5559

Commits
-------

fa36e1d [ClassLoader] Deprecate Apc/WinCache/Xcache class loaders
@nicolas-grekas nicolas-grekas deleted the depre-apc-classloader branch December 6, 2016 14:42
@Koc
Copy link
Contributor

Koc commented Dec 6, 2016

@stof there is also debug class loader that suggests how to deal with class not found errors

@stof
Copy link
Member

stof commented Dec 7, 2016

@Koc no. DebugClassLoader is in the Debug component, not in the ClassLoader component

xabbuh added a commit to symfony/symfony-docs that referenced this pull request Dec 25, 2016
This PR was merged into the master branch.

Discussion
----------

[ClassLoader] deprecate caching class loaders

Updates the documentation for symfony/symfony#20777.

Commits
-------

2e6cfca [ClassLoader] deprecate caching class loaders
@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
@fabpot fabpot mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants