Skip to content

Update performance.rst - "Caching the Autoloader with APC" section #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

cristi-contiu
Copy link
Contributor

@cristi-contiu cristi-contiu commented Oct 21, 2016

The example provided under "Caching the Autoloader with APC" is not in sync with the content of the 'app.php' file in Symfony 2.8:

Even on PHP 5.6 with built-in OPcache, I still see a performance boost from enabling the ApcClassLoader.

The example provided under "Caching the Autoloader with APC" is not in sync with the content of the 'app.php' file in Symfony 2.8:
* the comment hint was removed in symfony#964
* the autoloader was extracted from bootstrap: symfony/symfony-standard@747a384
@cristi-contiu cristi-contiu changed the title Update performance.rst Update performance.rst - "Caching the Autoloader with APC" section Oct 25, 2016
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2016

Thank you @cristi-contiu.

@xabbuh xabbuh merged commit 4127ad9 into symfony:2.8 Nov 28, 2016
xabbuh added a commit that referenced this pull request Nov 28, 2016
…" section (cristi-contiu)

This PR was merged into the 2.8 branch.

Discussion
----------

Update performance.rst - "Caching the Autoloader with APC" section

The example provided under "Caching the Autoloader with APC" is not in sync with the content of the 'app.php' file in Symfony 2.8:
- the comment hint was removed in symfony/symfony-standard#964
- the autoloader was extracted from bootstrap: symfony/symfony-standard@747a384

Even on PHP 5.6 with built-in OPcache, I still see a performance boost from enabling the ApcClassLoader.

Commits
-------

4127ad9 Update performance.rst
@stof
Copy link
Member

stof commented Nov 29, 2016

@cristi-contiu are you using the optimized composer autoloader ?

@teohhanhui
Copy link
Contributor

This whole section should be removed, since symfony/symfony#20777 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants