[Debug] Remove $context arg from handleError(), preparing for PHP 7.2 #21389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jan 24, 2017
| @@ -353,16 +353,14 @@ private function reRegister($prev) | |||
| * @param string $message | |||
| * @param string $file | |||
| * @param int $line | |||
| * @param array $context | |||
| * @param array $backtrace | |||
| * | |||
| * @return bool Returns false when no handling happens so that the PHP engine can handle the error itself | |||
| * | |||
| * @throws \ErrorException When $this->thrownErrors requests so | |||
| * | |||
| * @internal | |||
There was a problem hiding this comment.
Fortunately, this annotation is here from the beginning so we can change the signature without breaking our BC policy.
646b7b9 to
f3211db
Compare
|
is there still a case where we will provide a context to the exception ? If no, we should deprecate ContextErrorException (which is here only to add the context) |
|
Done in #21388 |
stof
reviewed
Jan 24, 2017
| if (isset($context['GLOBALS']) && ($this->scopedErrors & $type)) { | ||
| if (4 < $numArgs = func_num_args()) { | ||
| $context = $scope ? func_get_arg(4) : array(); | ||
| $backtrace = 5 < $numArgs ? func_get_arg(5) : null; |
There was a problem hiding this comment.
where is the backtrace comingfrom ? AFAIK, PHP never passes such argument
There was a problem hiding this comment.
In that case, can you add a small comment? That way, we can remove this piece of code more easily if we decide to drop HHVM support one day.
f3211db to
83cad14
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2017
…g for PHP 7.2 (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Remove $context arg from handleError(), preparing for PHP 7.2 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - PHP 7.2 will trigger deprecation notices. See https://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler Commits ------- 83cad14 [Debug] Remove $context arg from handleError(), preparing for PHP 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.2 will trigger deprecation notices.
See https://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler